fix autonat race #1062
Merged
fix autonat race #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #7947 move `BasicHost.AutoNat` to a private field (it has no public method and shouldn't be accessed afaik. Instead add a setter for config that sets it while holding the address mutex to prevent reads of the field at the same time.
mvdan
approved these changes
Mar 1, 2021
Stebalien
approved these changes
Mar 1, 2021
|
(someday we'll fix the dependency cycles here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ipfs/kubo#7947
move
BasicHost.AutoNatto a private field (it has no public method and shouldn't be accessed afaik.Instead add a setter for config that sets it while holding the address mutex to prevent reads of the
field at the same time.