Finish and Test the simultaneous connect problem in libp2p peers #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2021
Closed
aarshkshah1992
changed the title
config/security.go
Outdated
| secMuxer := new(csms.SSMuxer) | ||
| secMuxer.AddTransport(insecure.ID, insecure.NewWithIdentity(id, privKey)) | ||
| return secMuxer | ||
| } | ||
|
|
||
| func makeSecurityTransport(h host.Host, tpts []MsSecC) (sec.SecureTransport, error) { | ||
| func makeSecurityTransport(h host.Host, tpts []MsSecC) (sec.SecureMuxer, error) { |
|
cc @vyzo Please can you give me a review ? |
vyzo
approved these changes
Feb 14, 2021
raulk
reviewed
Feb 17, 2021
Comment on lines
+230
to
+233
| for i := 0; i < 20; i++ { | ||
| require.NoError(t, h1.Connect(context.Background(), h2Info)) | ||
| require.NoError(t, h1.Network().ClosePeer(h2.ID())) | ||
| } |
There was a problem hiding this comment.
Are 20 iterations sufficient to reliably trigger simopen?
There was a problem hiding this comment.
@raulk Pretty much.
Here's a run of the same test against v0.13.0(previous release, did not have hole punching), and it fails repeatedly:
aarshshah@Aarshs-MacBook-Pro go-libp2p % go test -run TestTcpSimultaneousConnect -count 10
--- FAIL: TestTcpSimultaneousConnect (0.28s)
libp2p_test.go:231:
Error Trace: libp2p_test.go:231
asm_amd64.s:1374
Error: Received unexpected error:
failed to dial QmZsP5W7ceKhynLcEtQpHXRTNTfd7i9YnBsnndwvmi5p3t: all dials failed
* [/ip4/192.168.43.87/tcp/50093] failed to negotiate security protocol: error reading handshake message: noise: message is too short
* [/ip4/127.0.0.1/tcp/50093] failed to negotiate security protocol: error reading handshake message: noise: message is too short
Test: TestTcpSimultaneousConnect
libp2p_test.go:241:
Error Trace: libp2p_test.go:241
asm_amd64.s:1374
Error: Received unexpected error:
failed to dial QmcMLKDi4aSWSkMk1W7pHY5uFiB6Wi7yKVzgVTY6oWL4an: all dials failed
* [/ip4/192.168.43.87/tcp/50092] failed to negotiate security protocol: error reading handshake message: noise: message is too short
* [/ip4/127.0.0.1/tcp/50092] failed to negotiate security protocol: error reading handshake message: noise: message is too short
Test: TestTcpSimultaneousConnect
--- FAIL: TestTcpSimultaneousConnect (0.23s)
libp2p_test.go:241:
Error Trace: libp2p_test.go:241
asm_amd64.s:1374
Error: Received unexpected error:
failed to dial Qmed9XqtjKjxEEoJi12PwKAf2NW35qkA6L2jffMEaodGQ2: all dials failed
* [/ip4/192.168.43.87/tcp/50095] failed to negotiate security protocol: error reading handshake message: noise: message is too short
* [/ip4/127.0.0.1/tcp/50095] failed to negotiate security protocol: error reading handshake message: noise: message is too short
Test: TestTcpSimultaneousConnect
libp2p_test.go:231:
Error Trace: libp2p_test.go:231
asm
...........................
...........................
FAIL
exit status 1
FAIL github.com/libp2p/go-libp2p 3.496s
Now, here's the same run with simultaneous connect feature:
aarshshah@Aarshs-MacBook-Pro go-libp2p % go test -run TestTcpSimultaneousConnect -count 10
go: downloading github.com/libp2p/go-libp2p-core v0.8.2
go: downloading github.com/libp2p/go-libp2p-transport-upgrader v0.4.2
go: downloading github.com/libp2p/go-libp2p-swarm v0.4.2
PASS
ok github.com/libp2p/go-libp2p 5.609s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes libp2p/go-libp2p-noise#70.
TODO