-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write coalescing breaks against buggy secio #644
Comments
Yeah, let's enable in next release. |
How can write coalescing break anything? All that Write should care about is the bytes in the slice passed to it, right? |
@marten-seemann check the details of the bug; secio would read more than requested if there was spare capacity in the buffer (which is frequent due to buffer pooling). The reader would then ignore the extra data or crash in the case of mplex. |
Most (at least 93%, likely more) has upgraded. These changes have been un-reverted and will be in go-ipfs 0.5.0. |
The bug fixed in libp2p/go-libp2p-secio#44 is causing problems with the new write coalescing patches. To reproduce:
Connect them and try to pin. This will fail.
To verify that this is really the issue, you can upgrade secio in 0.4.20 and only secio and the bug magically goes away.
Unfortunately... I think the only solution is to disable write coalescing for a release or two until the network upgrades.
The text was updated successfully, but these errors were encountered: