-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After repo consolidation, prune deps #1646
Comments
|
We now use the go dev's version, which is faster. Unfortunately, minio's sha256 implementation is still significantly faster than the built-in version, so we can't drop that yet. part of #1646
We now use the go dev's version, which is faster. Unfortunately, minio's sha256 implementation is still significantly faster than the built-in version, so we can't drop that yet. part of #1646
This needs to be done to be able to build with Go modules. When trying to compile go-libp2p/examples/chat copied to a standalone project
And perhaps |
I'm getting the exact same error when trying to use |
No, it's not, and this is totally not what this issue is about. You just need to make sure to import go-libp2p-core and go-libp2p versions that match (take the go-libp2p-core version from the respective go-libp2p version's go.mod file). |
I can confirm that I did this and the same problem occurs. |
I managed to resolve it on my side. Seems to have been from another package importing a different version and causing problems. |
I think we can close this issue now. There's not really anything we can't remove at this point. With #1979, we've also implemented @Stebalien's suggestion in #1646 (comment). |
This is an issue to remind us to sweep through our deps and remove anything that isn't necessary.
In the past week, I've removed our grpc dep and btcd dep. There are likely more around. This will be much easier after repo consolidation.
The text was updated successfully, but these errors were encountered: