Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestConnHandler is flaky #100

Closed
whyrusleeping opened this issue Sep 4, 2016 · 1 comment · Fixed by libp2p/go-libp2p-swarm#33
Closed

TestConnHandler is flaky #100

whyrusleeping opened this issue Sep 4, 2016 · 1 comment · Fixed by libp2p/go-libp2p-swarm#33
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue test_failure

Comments

@whyrusleeping
Copy link
Contributor

whyrusleeping commented Sep 4, 2016 •
edited
Loading

Every so often this one fails: https://travis-ci.org/libp2p/go-libp2p/jobs/156598013
@whyrusleeping whyrusleeping added test_failure help wanted Seeking public contribution on this issue labels Sep 4, 2016
@whyrusleeping
Copy link
Contributor Author

Another: https://travis-ci.org/libp2p/go-libp2p/jobs/158529467

@ghost ghost added status/deferred Conscious decision to pause or backlog and removed status/deferred Conscious decision to pause or backlog labels Nov 12, 2016
@whyrusleeping whyrusleeping added the status/deferred Conscious decision to pause or backlog label Nov 28, 2016
@daviddias daviddias added the exp/expert Having worked on the specific codebase is important label Aug 19, 2017
@Stebalien Stebalien added exp/novice Someone with a little familiarity can pick up and removed exp/expert Having worked on the specific codebase is important labels Aug 31, 2017
Stebalien added a commit to libp2p/go-libp2p-swarm that referenced this issue Aug 31, 2017
@Stebalien
test: connect each peer precisely once.
8f45dbf 
Otherwise, some tests will get confused by duplicate (temporary, we close
duplicates quickly) connections.

fixes libp2p/go-libp2p#100
@Stebalien Stebalien mentioned this issue Aug 31, 2017
Merged
@daviddias daviddias removed the status/deferred Conscious decision to pause or backlog label Aug 31, 2017
marten-seemann pushed a commit that referenced this issue Apr 21, 2022
@Stebalien
test: connect each peer precisely once.
755830e 
Otherwise, some tests will get confused by duplicate (temporary, we close
duplicates quickly) connections.

fixes #100
marten-seemann pushed a commit that referenced this issue Apr 21, 2022
@Kubuxu
Merge pull request #100 from libp2p/fix-logging-race
b601f9a 
Fix logging race
marten-seemann pushed a commit that referenced this issue Apr 22, 2022
@Stebalien
Merge pull request #100 from libp2p/chore/cleanup
f17510b 
chore: various cleanups required to get vet/staticcheck/test to pass
marten-seemann added a commit that referenced this issue Apr 26, 2022
@marten-seemann
Merge pull request #100 from libp2p/upgrader-interface
17c6e5e 
use the new transport.Upgrader interface
marten-seemann pushed a commit that referenced this issue Aug 17, 2022
@Stebalien
Merge pull request #100 from Mikerah/patch-1
1996269 
typo fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue test_failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: connect each peer precisely once. libp2p/go-libp2p-swarm
3 participants
@Stebalien @daviddias @whyrusleeping