This repository has been archived by the owner on May 26, 2022. It is now read-only.
listen on and dial security-enabled multiaddrs #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
marten-seemann
force-pushed
the
security-protocol-in-addr
branch
from
b1c882e
to
6a837b0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on basically all the other PRs listed in libp2p/go-libp2p#1194.
The high-level idea here is to add one
Transportfor every combination of TCP + handshake protocol (plus one that works exactly as it does now, which negotiates the security protocol using multistream). When listening on new addresses, and when dialing addresses, we inspect the multiaddr to see if it contains a security protocol, and then use the corresponding transport.