This repository has been archived by the owner on May 26, 2022. It is now read-only.
Fix dialLimiter.fdConsuming counting #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whyrusleeping Fixed the fix to actually fix what needed to be fixed. +Added a test for it |
whyrusleeping
approved these changes
Jul 31, 2017
Kubuxu
reviewed
Jul 31, 2017
limiter_test.go
Outdated
| if l.fdConsuming < 0 { | ||
| t.Fatalf("l.fdConsuming < 0") | ||
| } | ||
| fmt.Println(dials) |
There was a problem hiding this comment.
Best to remove the log here or use t.Log
There was a problem hiding this comment.
Didn't notice when doing commit, removed
Kubuxu
approved these changes
Jul 31, 2017
Stebalien
approved these changes
Jul 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ipfs/kubo#4102
With this fix when running daemon SYN_SENT connections are hovering around 150-200, which is a huge improvement from around 3000.
Unit tests are TODO