This repository has been archived by the owner on May 26, 2022. It is now read-only.
Feat/fix staticcheck #254
Closed
Feat/fix staticcheck #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 14, 2021 19:44
| err := p.Validate() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if p == s.local { | ||
| log.Event(ctx, "swarmDialSelf", logdial) | ||
| // log.Event(ctx, "swarmDialSelf", logdial) |
There was a problem hiding this comment.
@Stebalien, how are we supposed to deal with this?
Stebalien
suggested changes
Apr 20, 2021
| return nil, ErrDialToSelf | ||
| } | ||
|
|
||
| defer log.EventBegin(ctx, "swarmDialAttemptSync", p).Done() | ||
| // defer log.EventBegin(ctx, "swarmDialAttemptSync", p).Done() |
There was a problem hiding this comment.
Let's just delete these lines.
| @@ -111,7 +111,7 @@ func (s *Swarm) AddListenAddr(a ma.Multiaddr) error { | |||
| // ignore. | |||
| return | |||
| default: | |||
| log.Warningf("add conn %s failed: ", err) | |||
| log.Warnf("add conn %s failed: ", err) | |||
There was a problem hiding this comment.
If we're changing these, we might as well switch to a structured version:
log.Warnw("adding connection failed", "to", p, "error", err)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: protocol/.github#41