Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go-libp2p v0.25 #517

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Update to go-libp2p v0.25 #517

merged 2 commits into from
Feb 10, 2023

Conversation

MarcoPolo
Copy link
Contributor

I'm curious to see the test results in CI, because for me the tests are very flaky.

@MarcoPolo
Copy link
Contributor Author

Wow tests pass in CI but not my machine.

@Jorropo
Copy link

Jorropo commented Feb 10, 2023

I just spent fives minutes doing this, 🤦 🙏

Jorropo
Jorropo approved these changes Feb 10, 2023
View reviewed changes
Copy link

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jorropo Jorropo merged commit a14aca1 into master Feb 10, 2023
@Jorropo Jorropo deleted the marco/update-libp2p-v025 branch February 10, 2023 16:27
@masih
Copy link
Member

masih commented Feb 10, 2023

@Jorropo May I offer rum in exchange for releasing this commit please? 🥃

@Jorropo
Copy link

Jorropo commented Feb 10, 2023 •
edited
Loading

@masih is that a good or bad point ? 🤣
This repo does not have uCI, I got to do it by hand. 🙃 (git pull && git tag v0.9.0 && git push origin v0.9.0)

@masih
Copy link
Member

masih commented Feb 10, 2023

The promise of rum is secured regardless; thank you for the speedy release 🙏

@vyzo
Copy link
Collaborator

vyzo commented Feb 10, 2023

Really, what was the point of this release?

Pubsub only uses core interfaces really (modulo tests) and there should be absolutely no reason to upgrade libp2p unless there are breaking changes.

Also note that you are forcing downstream users to upgrade libp2p and its new bugs, which is really undesirable. Pubsub users should be free to use whatever minimum version they have vetted and tested with.

Please avoid doing this again in the future, unless there is a really good reason.

@masih
Copy link
Member

masih commented Feb 10, 2023

Code wouldn't compile without it I'm afraid:

github.com/libp2p/[email protected]/pubsub.go:314:32:  cannot use ps.protoMatchFunc(string(id)) (value of type func(string) bool) as type func(protocol.ID) bool in argument to h.SetStreamHandlerMatch

@vyzo
Copy link
Collaborator

vyzo commented Feb 10, 2023

Ok, so there was a breaking change.

Fair enough, but please list those reasons in the pr in the future, so that other users are aware of the incompatibility.

@masih
Copy link
Member

masih commented Feb 10, 2023

Of course! thanks @vyzo

@richard-ramos richard-ramos mentioned this pull request Feb 15, 2023
Merged
yhassanzadeh13 added a commit to yhassanzadeh13/go-libp2p-pubsub that referenced this pull request Jul 3, 2023
@yhassanzadeh13 @smrz2001
@MarcoPolo @richard-ramos @Wondertan @vyzo @nisdas @web-flow
Upgrades libp2p and pubsub versions (#16)
544e2fe 
* feat: expire messages from the cache based on last seen time (libp2p#513)

* feat: expire messages from the cache based on last seen time

* chore: minor renaming

* fix: messages should not be found after expiration

* chore: editorial

* fix: use new time cache strategy consistently

* fix: default to old time cache and add todo for background gc

* chore: update to go-libp2p v0.25 (libp2p#517)

* Update to go-libp2p v0.25

* Use go 1.19

* chore: update go version and dependencies (libp2p#516)

* fix(timecache): remove panic in first seen cache on Add (libp2p#522)

* Refactor timecache implementations (libp2p#523)

* reimplement timecache for sane and performant behaviour

* remove seenMessagesMx, take advantage of new tc api

* fix timecache tests

* fix typo

* store expiry, don't make life difficult

* refactor common background sweep procedure for both impls

* add godocs to TimeCache

* Default validator support (libp2p#525)

* add default validator support

* add an implementation for basic seqno as nonce validation

* missing return

* the nonce belongs to the origin peer

* add note about rust predicament

* add seqno validator tests

* minor test tweak, ensure at least 1ms before replay

* Fix Memory Leak In New Timecache Implementations (libp2p#528)

* fix bug

* add for last seen cache

* chore: Update .github/workflows/stale.yml [skip ci]

* chore: Update .github/workflows/stale.yml [skip ci]

* upgrades libp2p version

* upgrades libp2p version

---------

Co-authored-by: Mohsin Zaidi <[email protected]>
Co-authored-by: Marco Munizaga <[email protected]>
Co-authored-by: RichΛrd <[email protected]>
Co-authored-by: Hlib Kanunnikov <[email protected]>
Co-authored-by: vyzo <[email protected]>
Co-authored-by: Nishant Das <[email protected]>
Co-authored-by: GitHub <[email protected]>
yhassanzadeh13 added a commit to yhassanzadeh13/go-libp2p-pubsub that referenced this pull request Feb 20, 2024
@yhassanzadeh13 @smrz2001
@MarcoPolo @richard-ramos @Wondertan @vyzo @nisdas @web-flow @dependabot @chaitanyaprem @sukunrt
Upgrades libp2p version to v0.32 (#17)
03695de 
* feat: expire messages from the cache based on last seen time (libp2p#513)

* feat: expire messages from the cache based on last seen time

* chore: minor renaming

* fix: messages should not be found after expiration

* chore: editorial

* fix: use new time cache strategy consistently

* fix: default to old time cache and add todo for background gc

* chore: update to go-libp2p v0.25 (libp2p#517)

* Update to go-libp2p v0.25

* Use go 1.19

* chore: update go version and dependencies (libp2p#516)

* fix(timecache): remove panic in first seen cache on Add (libp2p#522)

* Refactor timecache implementations (libp2p#523)

* reimplement timecache for sane and performant behaviour

* remove seenMessagesMx, take advantage of new tc api

* fix timecache tests

* fix typo

* store expiry, don't make life difficult

* refactor common background sweep procedure for both impls

* add godocs to TimeCache

* Default validator support (libp2p#525)

* add default validator support

* add an implementation for basic seqno as nonce validation

* missing return

* the nonce belongs to the origin peer

* add note about rust predicament

* add seqno validator tests

* minor test tweak, ensure at least 1ms before replay

* Fix Memory Leak In New Timecache Implementations (libp2p#528)

* fix bug

* add for last seen cache

* chore: Update .github/workflows/stale.yml [skip ci]

* chore: Update .github/workflows/stale.yml [skip ci]

* bump golang.org/x/net from 0.4.0 to 0.7.0 (libp2p#520)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.4.0 to 0.7.0.
- [Release notes](https://github.com/golang/net/releases)
- [Commits](golang/net@v0.4.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: topicscore params can't be set for dynamically subscribed topic (libp2p#540)

* fix: topicscore params can't be set for a topic subscribed after gossipsub is initialized

* chore:address review comments

* Revert "fix: topicscore params can't be set for dynamically subscribed topic (libp2p#540)" (libp2p#541)

This reverts commit aa5fd79.

* remove usage of deprecated peerid.Pretty method (libp2p#542)

* chore: update go-libp2p to v0.32 (libp2p#548)

* chore: Update .github/workflows/stale.yml [skip ci]

* make tidy

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Mohsin Zaidi <[email protected]>
Co-authored-by: Marco Munizaga <[email protected]>
Co-authored-by: RichΛrd <[email protected]>
Co-authored-by: Hlib Kanunnikov <[email protected]>
Co-authored-by: vyzo <[email protected]>
Co-authored-by: Nishant Das <[email protected]>
Co-authored-by: GitHub <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Prem Chaitanya Prathi <[email protected]>
Co-authored-by: Sukun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorropo Jorropo Jorropo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarcoPolo @Jorropo @masih @vyzo