-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Application Specific RPC Inspector #509
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
c93e47a
Update go.mod
thep2p 19b4efd
Refactor GossipSub Construction (#1)
thep2p 7c7c05a
decouples options
thep2p c557ad4
Merge remote-tracking branch 'libp2p/master' into yahya/gossipsub-rou…
thep2p 5f71a48
fixes conflict
thep2p 1c1c946
reverts back module
thep2p ab8365c
fixes peer score helper
thep2p 5e7a682
Adds send control message to gossipsub router (#2)
thep2p b897e22
adjusts libp2p version (#3)
thep2p 1c91995
Merge branch 'yahya/gossipsub-router-interface'
thep2p 60457b3
Update go.mod (#4)
thep2p 6f0858c
adds app specific rpc handler
thep2p 3d47fa1
Create ci.yml (#5)
thep2p a94ddf3
Create Makefile (#7)
thep2p 26f8d34
Revert "Merge branch 'yahya/gossipsub-router-interface'" (#6)
thep2p 2e13ee8
Merge branch 'master' into yahya/adds-rpc-inspector
thep2p 1c99052
Update ci.yml (#9)
thep2p 352d747
Merge branch 'master' into yahya/adds-rpc-inspector
thep2p 40950fe
Revert "Merge branch 'master' into yahya/adds-rpc-inspector"
thep2p 586c5cb
Merge remote-tracking branch 'origin/yahya/adds-rpc-inspector' into y…
thep2p 221ca50
Revert "Merge remote-tracking branch 'origin/yahya/adds-rpc-inspector…
thep2p 653294a
Revert "Merge branch 'master' into yahya/adds-rpc-inspector"
thep2p 37df80c
moves app specific inspector to pubsub
thep2p 7f56708
removes option from gossipsub
thep2p e23f9ea
moves app specific rpc inspector up
thep2p 776d859
refactors app specific to return an error
thep2p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is already merged, but we probably want a docstring on this. Just wanted to flag this 🙂
cc @yhassanzadeh13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
I am ready to cut a release,but i'll wait for a docstring here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 PR incoming.