Abstracts GossipSubRouter interface #505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enables non-atomic validation for peer scoring parameters (libp2p#499) * decouples topic scoring parameters * adds skiping atomic validation for topic parameters * cleans up * adds skip atomic validation to peer score threshold * adds skip atomic validation for peer parameters * adds test for non-atomic validation * adds tests for peer score * adds tests for peer score thresholds * refactors tests * chore: Update .github/workflows/stale.yml [skip ci] * adds with gossipsub tracker Co-authored-by: libp2p-mgmt-read-write[bot] <104492852+libp2p-mgmt-read-write[bot]@users.noreply.github.com>
vyzo
reviewed
Nov 22, 2022
There was a problem hiding this comment.
Well, day of reckoning.... sigh.
I am really not fond of reifying and exposing the internal types like that, but i can accept it if there is no other way around it.
Are you sure this isnt the case?
Cant we just reify the router type and offer an interface you can use, without changing the internal plumbing?
These abstractions are not public proof and thre is cost associated with having to go through the interface potentially (hundreds of) thousands times per second.
| rt, err := DefaultGossipSubRouter(h) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to create default gossipsub router: %w", err) | ||
| } | ||
| opts = append(opts, WithRawTracer(rt.tagTracer)) |
There was a problem hiding this comment.
We need to find a way to absorb this (the tag tracer) into the defaults, it is very error prone to require it to be explicitly instantaited.
|
|
||
| gs.gossipTracer = newGossipTracer() | ||
| gs.SetGossipTracer(newGossipTracer()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Although in #503 we introduced injectible
PubSubRouterinto theGossipSub, there are several places in the code that initializing aGossipSubinstance with a customizedPubSubRouteris failing due to the strict type assertions, e.g., example-1, example-2, and example-3.Although the
rt(router) attribute of theGossipSubis deemed as aPubSubRouterinterface type, nevertheless through the initialization phase of theGossipSubthertattribute is strictly asserted as aGossipSubRoutervalue type. This is a blocker for initializingGossipSubwith customized wrappers aroundGossipSubRouteras it no longer is going to be aGossipSubRouterstrict value type. Hence the initialization fails with anpubsub router is not gossipsuberror.Contributions
In order to resolve the initialization failure due to the strict type assertions with
GossipSubRouterthis PR introduces the following changes:GossipPubSubRouterinterface type, and replaced strict type assertions with interface type assertions.GossipSubRouterstructtype from those deal with thePubSub.