Add preconnected nodes to pubsub #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alized as valid potential pubsub peers
|
Note: CI on this branch seems to be failing sometimes - I think the |
|
yeah, that test is flaky and it's getting on my nerves. |
vyzo
reviewed
Dec 7, 2020
vyzo
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PubSub only tries to add peers to the set of pubsub nodes when they connect. This meant that peers that were already connected to the host (e.g. tests, multiple nodes on the same machine, an application waiting a while to start up pubsub, etc.) would not get treated as pubsub nodes.
This resolves that by simply adding the list of already connected peers to pubsub.
Note: PubSub still does not utilize
Identifyevents to figure out if a peer supports one of the valid pubsub protocols or not, that other implementations of PubSub need to run a similar script instead of just toggling on and off support for a protocol like FloodSub.