providers: run datastore GC concurrently #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Stebalien
commented
Apr 19, 2019
| gcSkip map[string]struct{} | ||
| gcTime time.Time | ||
| gcTimer = time.NewTimer(pm.cleanupInterval) | ||
| ) |
There was a problem hiding this comment.
I've tried breaking this out into a separate struct but it really doesn't help.
Motivation: Walking the datastore can take time and currently blocks adding/removing providers. We need to do this in the same goroutine to avoid some logical races.
Stebalien
force-pushed
the
feat/optimize-provider-gc-3
branch
from
79aec7e to
e7e9186
Compare
vyzo
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Walking the datastore can take time and currently blocks adding/removing providers.
We need to do this in the same goroutine to avoid some logical races.
Alternative to #324