refactor: return nil instead of an empty record when processing an in…

…valid record
libp2p · Oct 7, 2020 · 197ecae · 197ecae
1 parent 05306f1
commit 197ecae
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/wire/messages.go b/wire/messages.go
@@ -104,8 +104,7 @@ func (pm *ProtocolMessenger) GetValue(ctx context.Context, p peer.ID, key string
 		if err != nil {
 			logger.Debug("received invalid record (discarded)")
 			// return a sentinel to signify an invalid record was received
-			err = internal.ErrInvalidRecord
-			rec = new(recpb.Record)
+			return nil, peers, internal.ErrInvalidRecord
 		}
 		return rec, peers, err
 	}