Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use go-libp2p-core 0.7.0 stream interfaces #60

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Conversation

Stebalien
Copy link
Member

Copy link

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In listener.go we Reset the stream when it's closed instead of calling Close on it, is that intentional?

@Stebalien
Copy link
Member Author

In listener.go we Reset the stream when it's closed instead of calling Close on it, is that intentional?

We reset the stream when the listener is closed before the stream has been accepted. In other words, we're aborting the accept.

@Stebalien Stebalien merged commit 9c9ec16 into master Nov 12, 2020
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants