Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

block while writing #10

Merged
merged 1 commit into from
Apr 26, 2019
Merged

block while writing #10

merged 1 commit into from
Apr 26, 2019

Conversation

Stebalien
Copy link
Member

Make sure to wait until we're done writing before returning. The close should interrupt this process but we should still wait.

might be related to ipfs/kubo#6197

Make sure to wait until we're done writing before returning. The close should
interrupt this process but we should still wait.

might be related to ipfs/kubo#6197
@ghost ghost assigned Stebalien Apr 26, 2019
@ghost ghost added the status/in-progress In progress label Apr 26, 2019
@Stebalien Stebalien requested a review from vyzo April 26, 2019 02:27
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully this will not block forever!

@Stebalien
Copy link
Member Author

hopefully this will not block forever!

If it did, we have a goroutine leak anyways.

@Stebalien Stebalien merged commit 93a5f4d into master Apr 26, 2019
@Stebalien Stebalien deleted the fix/block-while-writing branch April 26, 2019 08:34
@ghost ghost removed the status/in-progress In progress label Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants