Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stork version annotation for backup, backupschedule and restore CR. #724

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

siva-portworx
Copy link
Contributor

@siva-portworx siva-portworx commented Sep 30, 2020

What type of PR is this?

Uncomment only one and also add the corresponding label in the PR:
feature

What this PR does / why we need it:
Added stork version annotation, which will be updated by stork for backup, backupschedule and restore CR.

Does this PR change a user-facing CRD or CLI?:
no

Is a release note needed?:
N.A.

Does this change need to be cherry-picked to a release branch?:
2.6

Manual Testing:
For backup object
:

[root@central-hail-hand-0 px-backup]# kubectl describe applicationbackup siva2-2fcc3c6 -n kube-system
Name:         siva2-2fcc3c6
Namespace:    kube-system
Labels:       <none>
Annotations:  portworx.io/backup-name: siva2
              portworx.io/backup-uid: 2fcc3c6b-c345-4e16-93a2-7064024f9bf5
              portworx.io/backuplocation-name: backuplocation1
              portworx.io/cluster-name: cluster1
              portworx.io/cluster-uid: 3f8342ae-d07c-43bf-89be-d5a95d74e3d1
              portworx.io/created-by: px-backup
              portworx.io/last-update: 2020-09-30T03:37:41.665120916Z
              portworx.io/org-id: org1
              portworx.io/skip-backup-location-name-check: true
              stork.libopenstorage.org/storkVersion: 2.5.0-eb6c180
API Version:  stork.libopenstorage.org/v1alpha1
Kind:         ApplicationBackup
...........

@disrani-px disrani-px modified the milestones: 2.6.1, 2.6.2 Dec 17, 2020
	- Already completed CR, whether success/failed, the stork version will not
	  be updated as it was created by previous stork version.
@cnbu-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants