Add encrypted volume to mysql-1-pvc app #547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disrani-px
reviewed
Feb 11, 2020
| annotations: | ||
| volume.beta.kubernetes.io/storage-class: px-mysql-sc | ||
| px/secret-name: volume-secrets | ||
| px/secret-namespace: mysql-1-pvc-mysql |
There was a problem hiding this comment.
The secret won't be in that namespace, it is auto-generated for most tests
|
Rohit-PX
force-pushed
the
add_encry_vol_mysql
branch
from
c3921c1 to
cf9ecf9
Compare
|
@Rohit-PX Can you run all the tests to make sure nothing is broken? That app is used by other tests too |
disrani-px
added
the
integration-test
Rohit-PX
force-pushed
the
add_encry_vol_mysql
branch
from
34a36dc to
ddd7c30
Compare
Signed-off-by: Rohit-PX <[email protected]>
Rohit-PX
force-pushed
the
add_encry_vol_mysql
branch
from
0fdd5a3 to
23ead03
Compare
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
+ Coverage 76.86% 77.64% +0.77%
==========================================
Files 33 32 -1
Lines 3653 3601 -52
==========================================
- Hits 2808 2796 -12
+ Misses 615 576 -39
+ Partials 230 229 -1
Continue to review full report at Codecov.
|
disrani-px
approved these changes
May 27, 2020
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rohit-PX [email protected]
What type of PR is this?
integration-test
What this PR does / why we need it:
Adding an encrypted volume to the mysql app
Does this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
no
Does this change need to be cherry-picked to a release branch?:
no