Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendoring kdmp repo from master branch #1457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

siva-portworx
Copy link
Contributor

What type of PR is this?

Uncomment only one and also add the corresponding label in the PR:
bug

What this PR does / why we need it:

pb-4023: Added code to clean up the VS and VSC in the case of KDMP & …
…localsnapshot.

	- Need to delete the volumesnapshot and volumesnapshotcontent for KDMP + localsnapshot backup variant in the following cases.
        	- When the S3 and NFS backuplocation localsnapshot fails with KDMP + localsnapshot.
          	  It is possible that CSI snapshot might fails with timeout error, if the snapshot takes time or snapshot is not support by CSI controller.
		- When the snapshot succeeds with S3 backuplocation/KDMP + localsnapshot, we need to delete the VS and VSC, in the volume stage itself.
		- When the snapshot succeeds with NFS backuplocation/KDMP + localsnapshot, we will NOT delete the VS and VSC in the volume stage.
		  It will be deleted in the resource stage after the VS and VSC spec is uploaded to NFS location as part of job pod.
	- Made the reason update in dataExport CR to be default as we need to need to reset the reason field to empty in the case of success.

Does this PR change a user-facing CRD or CLI?:

Is a release note needed?:

release-note
Issue: The volumesnapshot and volumesnapshotcontent custom resources are not getting cleaned up in the case of KDMP +localsnapshot variant.
User Impact: The volumesnapsot and volumesnapshotcontent will get accumulated on the cluster.
Resolution: Cleaning up the volumesnapshot and voumesnapshotcontent after the completion of the backup and restore in the case of KDMP + localsnapshot.

Does this change need to be cherry-picked to a release branch?:
23.6.1 and 23.7.0 stork branch ( from 1.2.7 kdmp branch)

@cnbu-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants