PWX-27385: Honor IncludeResources flag when entering Application stage. #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The migration controller was not honoring the IncludeResources flag and was trying to migrate all the resources even if IncludeResources was set to false. - Add comments to the MigrationSpec.
adityadani
commented
Nov 22, 2022
| @@ -2131,30 +2137,28 @@ func (m *MigrationController) getMigrationSummary(migration *stork_api.Migration | |||
| migrationSummary.ElapsedTimeForVolumeMigration = elapsedTimeVolume | |||
| } | |||
|
|
|||
| if migration.Spec.IncludeResources == nil || *migration.Spec.IncludeResources { | |||
There was a problem hiding this comment.
We should calculate the MigrationSummary and populate the time taken for migration k8s resources, even if IncludeResources is set to false, since we would be migrating the PV and PVC objects.
|
Can one of the admins verify this patch? |
diptiranjanpx
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The migration controller was not honoring the IncludeResources flag and was
trying to migrate all the resources even if IncludeResources was set to false.
Add comments to the MigrationSpec.
Does this PR change a user-facing CRD or CLI?:
No
Is a release note needed?:
Yes
Does this change need to be cherry-picked to a release branch?:
Yes - 2.12