Integration test for clusterpairing using backuplocation #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ram-infrac
added
the
integration-test
Signed-off-by: Ram <[email protected]>
| func scheduleClusterPair(ctx *scheduler.Context, skipStorage, resetConfig bool, clusterPairDir string, reverse bool) error { | ||
| func scheduleClusterPair(t *testing.T, ctx *scheduler.Context, skipStorage, resetConfig bool, clusterPairDir string, reverse bool) error { | ||
| info := make(map[string]string) | ||
| enabled, err := strconv.ParseBool(os.Getenv(enableClusterPairBackupLocation)) |
There was a problem hiding this comment.
nit: enabled is a vague variable name
| @@ -558,12 +569,11 @@ func scheduleClusterPair(ctx *scheduler.Context, skipStorage, resetConfig bool, | |||
| } | |||
| } | |||
|
|
|||
| info, err := volumeDriver.GetClusterPairingInfo() | |||
| info, err = volumeDriver.GetClusterPairingInfo() | |||
There was a problem hiding this comment.
This will overwrite the info we modified above?
Rohit-PX
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Looks good as long as @lpitstickpstg 's comments are addressed.
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Integration test for using backuplocation for clusterpair
Does this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
no
Does this change need to be cherry-picked to a release branch?:
yes, 2.9