in-tree: Add check for empty secret/context on create/delete #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityadani
reviewed
Mar 18, 2019
ggriffiths
force-pushed
the
intree_no_secret_improve_error_msg
branch
from
38df4a5 to
26543e4
Compare
ggriffiths
force-pushed
the
intree_no_secret_improve_error_msg
branch
2 times, most recently
from
5acddde to
975470a
Compare
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
force-pushed
the
intree_no_secret_improve_error_msg
branch
from
975470a to
81eb976
Compare
lpabon
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Grant Griffiths [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #953
Special notes for your reviewer: