SDK will now return a volume only if it is ready #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpabon
force-pushed
the
b1180
branch
2 times, most recently
from
24f1365 to
b2d897c
Compare
harsh-px
reviewed
Sep 4, 2019
harsh-px
approved these changes
Sep 5, 2019
With this fix, any call creating a volume and noticing it already exists now checks to make sure that the volume is UP and ready before returning. Closes libopenstorage#1180 Signed-off-by: Luis Pabón <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With this fix, any call creating a volume and noticing it already
exists now checks to make sure that the volume is UP and ready
before returning.
Which issue(s) this PR fixes (optional)
Closes #1180
Special notes for your reviewer:
pkg/utilcalledWaitForWithContextwhich will automatically use the passed default value or the Deadline (WithTimeout) value passed in the context by the caller.