CSI 1.1 Implementation #1087
Closed
CSI 1.1 Implementation #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Griffiths <[email protected]>
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
commented
Apr 25, 2019
| @@ -266,6 +276,17 @@ func (s *OsdCsiServer) CreateVolume( | |||
| return nil, status.Error(codes.InvalidArgument, e) | |||
| } | |||
|
|
|||
| // Get parent ID from request: snapshot or volume | |||
There was a problem hiding this comment.
A new csi-sanity test checks for this feature. It seems we missed it in the past. This results in a volume snapshot within our driver.
I can change this if needed, but this seemed to make the most sense to me.
ggriffiths
commented
Apr 25, 2019
| capExpandVolume := &csi.ControllerServiceCapability{ | ||
| Type: &csi.ControllerServiceCapability_Rpc{ | ||
| Rpc: &csi.ControllerServiceCapability_RPC{ | ||
| Type: csi.ControllerServiceCapability_RPC_EXPAND_VOLUME, |
There was a problem hiding this comment.
We only need to implement ControllerServiceCapability_RPC_EXPAND_VOLUME as opposed to the Node Volume Expand capability, as our volumes can be resized while online (mounted)
|
Closing this until I fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #1086
Special notes for your reviewer: