Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for authProviderType before initializing secretsStore #974

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Add check for authProviderType before initializing secretsStore #974

merged 1 commit into from
Mar 21, 2019

Conversation

ggriffiths
Copy link
Contributor

@ggriffiths ggriffiths commented Mar 21, 2019 •
edited
Loading

Signed-off-by: Grant Griffiths [email protected]

What this PR does / why we need it:

  • If authProviderType is none, we should not attempt to initialize SecretsStore.

Which issue(s) this PR fixes (optional)
Closes #975

Special notes for your reviewer:

@ggriffiths ggriffiths requested a review from jrivera-px March 21, 2019 21:48
jrivera-px
jrivera-px approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@jrivera-px jrivera-px left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ggriffiths ggriffiths merged commit 7f43b1e into libopenstorage:master Mar 21, 2019
@ggriffiths ggriffiths deleted the add_authprovidertype_validation branch March 21, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrivera-px jrivera-px jrivera-px approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should check authProviderType before initializing secretsStore
2 participants
@ggriffiths @jrivera-px