New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should check authProviderType before initializing secretsStore #975

Closed

ggriffiths opened this issue Mar 21, 2019 · 0 comments · Fixed by #974

Assignees

Contributor

ggriffiths commented Mar 21, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

What happened:

authProviderType was none, so initializing secretsStore failed.

What you expected to happen:

secretsStore should not be initialized. We will not call to secretsStore as a result, just like when authProvider is nil.

ggriffiths self-assigned this

ggriffiths mentioned this issue

Add check for authProviderType before initializing secretsStore #974

Merged

ggriffiths closed this as completed in #974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment