Do not mask post-attach inspect errors (#1204)

Signed-off-by: veda <[email protected]>
libopenstorage · Aug 27, 2019 · fc6a1bb · fc6a1bb
1 parent 636d0e4
commit fc6a1bb
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/api/server/volume.go b/api/server/volume.go
@@ -429,11 +429,19 @@ func (vd *volAPI) volumeSet(w http.ResponseWriter, r *http.Request) {
 	})
 	if err2 != nil {
 		resp.Volume = &api.Volume{}
+		if req.Action.IsAttach() {
+			resp.VolumeResponse = &api.VolumeResponse{
+				Error: responseStatus(err2),
+			}
+		}
 	} else {
 		resp.Volume = resVol.GetVolume()
 	}
-	resp.VolumeResponse = &api.VolumeResponse{
-		Error: responseStatus(err),
+	// Do not clear inspect err for attach
+	if err != nil {
+		resp.VolumeResponse = &api.VolumeResponse{
+			Error: responseStatus(err),
+		}
 	}
 	json.NewEncoder(w).Encode(resp)