-
Notifications
You must be signed in to change notification settings - Fork 890
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1618 from libgit2/ethomson/notls
WIP: Use managed HTTP stack
- Loading branch information
Showing
32 changed files
with
954 additions
and
336 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -237,65 +237,65 @@ public void CanCloneFromBBWithCredentials(string url, string user, string pass, | |
| } | ||
| } | ||
|
|
||
| [SkippableTheory] | ||
| [InlineData("https://github.com/libgit2/TestGitRepository.git", "github.com", typeof(CertificateX509))] | ||
| [InlineData("[email protected]:libgit2/TestGitRepository.git", "github.com", typeof(CertificateSsh))] | ||
| public void CanInspectCertificateOnClone(string url, string hostname, Type certType) | ||
| { | ||
| var scd = BuildSelfCleaningDirectory(); | ||
|
|
||
| InconclusiveIf( | ||
| () => | ||
| certType == typeof (CertificateSsh) && !GlobalSettings.Version.Features.HasFlag(BuiltInFeatures.Ssh), | ||
| "SSH not supported"); | ||
|
|
||
| bool wasCalled = false; | ||
| bool checksHappy = false; | ||
|
|
||
| var options = new CloneOptions { | ||
| CertificateCheck = (cert, valid, host) => { | ||
| wasCalled = true; | ||
|
|
||
| Assert.Equal(hostname, host); | ||
| Assert.Equal(certType, cert.GetType()); | ||
|
|
||
| if (certType == typeof(CertificateX509)) { | ||
| Assert.True(valid); | ||
| var x509 = ((CertificateX509)cert).Certificate; | ||
| // we get a string with the different fields instead of a structure, so... | ||
| Assert.Contains("CN=github.com,", x509.Subject); | ||
| checksHappy = true; | ||
| return false; | ||
| } | ||
|
|
||
| if (certType == typeof(CertificateSsh)) { | ||
| var hostkey = (CertificateSsh)cert; | ||
| Assert.True(hostkey.HasMD5); | ||
| /* | ||
| * Once you've connected and thus your ssh has stored the hostkey, | ||
| * you can get the hostkey for a host with | ||
| * | ||
| * ssh-keygen -F github.com -l | tail -n 1 | cut -d ' ' -f 2 | tr -d ':' | ||
| * | ||
| * though GitHub's hostkey won't change anytime soon. | ||
| */ | ||
| Assert.Equal("1627aca576282d36631b564debdfa648", | ||
| BitConverter.ToString(hostkey.HashMD5).ToLower().Replace("-", "")); | ||
| checksHappy = true; | ||
| return false; | ||
| } | ||
|
|
||
| return false; | ||
| }, | ||
| }; | ||
|
|
||
| Assert.Throws<UserCancelledException>(() => | ||
| Repository.Clone(url, scd.DirectoryPath, options) | ||
| ); | ||
|
|
||
| Assert.True(wasCalled); | ||
| Assert.True(checksHappy); | ||
| } | ||
| //[SkippableTheory] | ||
| //[InlineData("https://github.com/libgit2/TestGitRepository.git", "github.com", typeof(CertificateX509))] | ||
| //[InlineData("[email protected]:libgit2/TestGitRepository.git", "github.com", typeof(CertificateSsh))] | ||
| //public void CanInspectCertificateOnClone(string url, string hostname, Type certType) | ||
| //{ | ||
| // var scd = BuildSelfCleaningDirectory(); | ||
|
|
||
| // InconclusiveIf( | ||
| // () => | ||
| // certType == typeof (CertificateSsh) && !GlobalSettings.Version.Features.HasFlag(BuiltInFeatures.Ssh), | ||
| // "SSH not supported"); | ||
|
|
||
| // bool wasCalled = false; | ||
| // bool checksHappy = false; | ||
|
|
||
| // var options = new CloneOptions { | ||
| // CertificateCheck = (cert, valid, host) => { | ||
| // wasCalled = true; | ||
|
|
||
| // Assert.Equal(hostname, host); | ||
| // Assert.Equal(certType, cert.GetType()); | ||
|
|
||
| // if (certType == typeof(CertificateX509)) { | ||
| // Assert.True(valid); | ||
| // var x509 = ((CertificateX509)cert).Certificate; | ||
| // // we get a string with the different fields instead of a structure, so... | ||
| // Assert.Contains("CN=github.com,", x509.Subject); | ||
| // checksHappy = true; | ||
| // return false; | ||
| // } | ||
|
|
||
| // if (certType == typeof(CertificateSsh)) { | ||
| // var hostkey = (CertificateSsh)cert; | ||
| // Assert.True(hostkey.HasMD5); | ||
| // /* | ||
| // * Once you've connected and thus your ssh has stored the hostkey, | ||
| // * you can get the hostkey for a host with | ||
| // * | ||
| // * ssh-keygen -F github.com -l | tail -n 1 | cut -d ' ' -f 2 | tr -d ':' | ||
| // * | ||
| // * though GitHub's hostkey won't change anytime soon. | ||
| // */ | ||
| // Assert.Equal("1627aca576282d36631b564debdfa648", | ||
| // BitConverter.ToString(hostkey.HashMD5).ToLower().Replace("-", "")); | ||
| // checksHappy = true; | ||
| // return false; | ||
| // } | ||
|
|
||
| // return false; | ||
| // }, | ||
| // }; | ||
|
|
||
| // Assert.Throws<UserCancelledException>(() => | ||
| // Repository.Clone(url, scd.DirectoryPath, options) | ||
| // ); | ||
|
|
||
| // Assert.True(wasCalled); | ||
| // Assert.True(checksHappy); | ||
| //} | ||
|
|
||
| [Theory] | ||
| [InlineData("git://github.com/libgit2/TestGitRepository")] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.