Support id for GeoJSONFeature #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kunlinyu
commented
Nov 15, 2023
kunlinyu
commented
- Add id and getter for GeoJSONFeature
- Modify the copy constructor of GeoJSONFeature
- Check "id" in GeoJSONReader
- Check "id" in GeoJSONWriter
- Modify unit test for id
1. Add id and getter for GeoJSONFeature 2. Modify the copy constructor of GeoJSONFeature 3. Check "id" in GeoJSONReader 4. Check "id" in GeoJSONWriter 5. Modify unit test for id Signed-off-by: Kunlin Yu <[email protected]>
rouault
reviewed
Nov 19, 2023
src/io/GeoJSONReader.cpp
Outdated
| return GeoJSONFeature{readGeometry(geometryJson), readProperties(properties)}; | ||
|
|
||
| std::string id = ""; | ||
| if (j.contains("id")) id = j.at("id").get<std::string>(); |
There was a problem hiding this comment.
will that work if "id" is null, or some non-string type ?
Signed-off-by: Kunlin Yu <[email protected]>
rouault
reviewed
Nov 21, 2023
src/io/GeoJSONReader.cpp
Outdated
| std::string id = ""; | ||
| if (j.contains("id") && !j.at("id").is_null()) { | ||
| if (j.at("id").is_string()) id = j.at("id").get<std::string>(); | ||
| if (j.at("id").is_number()) id = std::to_string(j.at("id").get<int>()); |
There was a problem hiding this comment.
does get() works fine on floating-point numbers ?
There was a problem hiding this comment.
It works fine but I think it is not correct. According to the geojson standard, all number is valid. So we have to support float point. I will upload a patch soon.
Use "dump()" instead of get<int>() or get<float>() to make code clear. And notice that both 123.0 and 123.000 will be parsed as "123.0" because nlohmann/json will cut the suffix 0 by default. It is hard to support float well. But I think use floating-point as id is not a good practice. So I think then current implementation is acceptable. Signed-off-by: Kunlin Yu <[email protected]>
rouault
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.