Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added illumos macro for int8_t parse_value override. #971

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jMichaelA
Copy link
Contributor

illumos' implementation of stdint.h treats chars as int8_t. So when I was trying to compile this on an illumos distro I was getting the following compilation error:

/usr/local/src/geos-3.12.0/util/geosop/cxxopts.hpp:793:10: error: redefinition of 'void cxxopts::values::parse_value(const string&, char&)'
  793 |     void parse_value(const std::string& text, char& c)
      |          ^~~~~~~~~~~
/usr/local/src/geos-3.12.0/util/geosop/cxxopts.hpp:682:5: note: 'void cxxopts::values::parse_value(const string&, int8_t& ' previously defined here
  682 |     parse_value(const std::string& text, int8_t& value)
      |     ^~~~~~~~~~~

So this change will only add one of the functions if it's an illumOS system.

@pramsey pramsey merged commit f253008 into libgeos:main Nov 14, 2023
@pramsey
Copy link
Member

pramsey commented Nov 14, 2023

Thanks!

pramsey pushed a commit that referenced this pull request Nov 14, 2023
pramsey added a commit that referenced this pull request Nov 14, 2023
pramsey pushed a commit that referenced this pull request Nov 14, 2023
pramsey added a commit that referenced this pull request Nov 14, 2023
pramsey pushed a commit that referenced this pull request Nov 14, 2023
pramsey added a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants