Fix CMake on Windows with Visual Studio #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid setting CMAKE_BUILD_TYPE default when multi-config generators are used. Avoid setting CMAKE_BUILD_TYPE STRINGS property if it is not a cache variable. This avoids CMake errors if CMAKE_BUILD_TYPE isn't set on the command-line. Closes libgeos#932
|
Well, this builds/test OK on my local env (MacOX 13.5, |
hobu
approved these changes
Aug 11, 2023
|
Are there any other reviews needed before merging in this PR? I don't have permissions to merge, so someone else will need to press the button. |
|
Was hoping @dbaston would weigh in, but time and tide... |
|
Not much experience building with MSVC, sorry. If it works for the author and Howard, it should be fine. |
|
@pramsey I should note that this was merged into the 3.12 branch, so it should be cherry-picked onto main at some point. Not sure if that's something you want to handle or if you want me to submit another PR. |
mwtoews
pushed a commit
that referenced
this pull request
Aug 17, 2023
Avoid setting CMAKE_BUILD_TYPE default when multi-config generators are used. Avoid setting CMAKE_BUILD_TYPE STRINGS property if it is not a cache variable. This avoids CMake errors if CMAKE_BUILD_TYPE isn't set on the command-line. Closes #932
|
Cherry-picked to |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid setting CMAKE_BUILD_TYPE default when multi-config generators are used.
Avoid setting CMAKE_BUILD_TYPE STRINGS property if it is not a cache variable. This avoids CMake errors if CMAKE_BUILD_TYPE isn't set on the command-line.
Closes #932