Fix OffsetCurve to use a minimum QuadrantSegs value #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pramsey
commented
May 26, 2023
pramsey
commented
- Port Fix OffsetCurve to use a minimum QuadrantSegs value locationtech/jts#981
- References QGIS offset line shows perpendicular tags issue qgis/QGIS#53165
- References Offset curve has Weird Geometry #897
References qgis/QGIS#53165 References libgeos#897
…anks to the min quadsegs, and one was a shorter line, but still seemed reasonable, in capi::GEOSOffsetCurve::5
strk
approved these changes
May 29, 2023
| @@ -104,7 +104,7 @@ void object::test<3>() | |||
| { | |||
| checkOffset( | |||
| "LINESTRING(0 0, 10 0, 10 10)", | |||
| "LINESTRING (12 10, 12 0, 10 -2, 0 -2)", | |||
| "LINESTRING (0 -2, 10 -2, 10.390180644 -1.9615705608, 10.7653668647 -1.847759065, 11.111140466 -1.6629392246, 11.4142135624 -1.4142135624, 11.6629392246 -1.111140466, 11.847759065 -0.7653668647, 11.9615705608 -0.390180644, 12 0, 12 10)", | |||
| -2, 1, GEOSBUF_JOIN_ROUND, 2, | |||
| 0.000001 | |||
There was a problem hiding this comment.
Note that the last argument is a tolerance, so there's no need for more than 6 decimal digits with the current tolerance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.