Change WKBWriter default output dimension to 4 #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me, although maybe a little less user facing than the WKT writer change. As long as people are only ever getting the dimensionality they put in, seems like a net reduction in user surprise, which is +1 :) |
mwtoews
force-pushed
the
change-wkbwriter-defaults
branch
from
896a695 to
4360451
Compare
BuonOmo
added a commit
to rgeo/rgeo
that referenced
this pull request
Aug 23, 2023
The 3.12 include changes in the API responses. Mainly, WBX Writers now default to three dimensions instead of two. We follow the changes, making no breaking change in the API, but some changes in the responses given by `#ccw?` and `#simplify_preserve_topology`. See changes in libgeos: - libgeos/geos#784 - libgeos/geos#878 - libgeos/geos#908 - libgeos/geos#915 Fixes #360
BuonOmo
added a commit
to rgeo/rgeo
that referenced
this pull request
Aug 23, 2023
The 3.12 include changes in the API responses. Mainly, WBX Writers now default to three dimensions instead of two. We follow the changes, making no breaking change in the API, but some changes in the responses given by `#ccw?` and `#simplify_preserve_topology`. See changes in libgeos: - libgeos/geos#784 - libgeos/geos#878 - libgeos/geos#908 - libgeos/geos#915 Fixes #360
BuonOmo
added a commit
to rgeo/rgeo
that referenced
this pull request
Aug 23, 2023
The 3.12 include changes in the API responses. Mainly, WBX Writers now default to three dimensions instead of two. We follow the changes, making no breaking change in the API, but some changes in the responses given by `#ccw?` and `#simplify_preserve_topology`. See changes in libgeos: - libgeos/geos#784 - libgeos/geos#878 - libgeos/geos#908 - libgeos/geos#915 Fixes #360
BuonOmo
added a commit
to rgeo/rgeo
that referenced
this pull request
Aug 24, 2023
The 3.12 include changes in the API responses. Mainly, WBX Writers now default to three dimensions instead of two. We follow the changes, making no breaking change in the API, but some changes in the responses given by `#ccw?` and `#simplify_preserve_topology`. See changes in libgeos: - libgeos/geos#784 - libgeos/geos#878 - libgeos/geos#908 - libgeos/geos#915 Fixes #360
ejn
pushed a commit
to dvzgeo/php-geos
that referenced
this pull request
Mar 14, 2024
2, 3, or 4 dimensions. Default since GEOS 3.12 is 4. see: libgeos/geos#908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This potentially breaking change with the WKBWriter is to use output dimension 4.
For example,
POINT Z (1.1 2.2 3.3)via writeHEX using defaults:01010000009A9999999999F13F9A99999999990140orPOINT (1.1 2.2)01010000809A9999999999F13F9A999999999901406666666666660A40same as input WKTAlso add a few additional tests related to
setOutputDimensionthat didn't seem to be covered.