Fix invalid values from CoverageUnionNG #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramsey
approved these changes
Jan 14, 2025
|
This is probably too minor to add to NEWS, but worth backporting to |
mwtoews
added a commit
that referenced
this pull request
Jan 15, 2025
mwtoews
added a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an invalid value message shown in shapely:
>>> import shapely >>> shapely.geos_version_string '3.13.0' >>> shapely.coverage_union_all([]) /home/mtoews/src/shapely/shapely/shapely/set_operations.py:505: RuntimeWarning: invalid value encountered in coverage_union return lib.coverage_union(collections, **kwargs) <GEOMETRYCOLLECTION EMPTY>This is caused by a division by zero in GEOS'
CoverageUnion::geomunion()with coverage inputs that are empty or don't have an area.Tests 9 to 14 were silently throwing this warning too, as these input coverages don't have an area.