GeometryCollection: Cache flags to avoid O(n) lookups #1220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in locationtech/jts#1100. For a collection with 1 million elements, reduces CoverageUnion runtime by 98%.
Increases the size of collections from 88 to 96 bytes. This could be avoided by storing the flags in
Geometry
(which has 4 spare bytes) rather thanGeometryCollection
(which has none).This PR:
main: