New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SegmentSetMutualIntersector for dll-interface class and other MSVC warnings #1146

Merged

pramsey merged 1 commit into libgeos:main from mwtoews:msvc-warnings-3.13b1

Aug 21, 2024

Contributor

mwtoews commented Aug 19, 2024 •

edited

Loading

This PR addresses two MSVC warnings (only shown in developer mode; e.g. see previous build logs):

22 instances of C4275: non dll-interface class 'geos::noding::SegmentSetMutualIntersector' used as base for dll-interface class 'geos::noding::MCIndexSegmentSetMutualIntersector'. The fix is to add GEOS_DLL to SegmentSetMutualIntersector
1 instance of C4101: warning C4101: 'iae': unreferenced local variable. The fix is to remove the unused variable.

This does not currently fix:

2 instances of C4244: conversion from '_Ty' to 'uint8_t', possible loss of data. This applies to src/operation/GeometryGraphOperation.cpp#L58 and src/util/string.cpp#L59. Suggestions are welcome, as I'm unable to resolve these warnings.


          Add SegmentSetMutualIntersector for dll-interface class

2bf662b

pramsey merged commit b9c2fd0 into libgeos:main

28 checks passed

mwtoews deleted the msvc-warnings-3.13b1 branch

August 21, 2024 22:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet