Fix MaximumInscribedCircle::computeMaximumIterations for small values #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Potentially a similar fix would be good with JTS here too. Wait, never mind, nothing wrong with JTS here since ints can safely go negative. A counter-fix for GEOS is to set factor to a signed int, similar to JTS. It's also probably not a big deal too. |
|
Might be nice to keep the codebases more in synch - by using the signed int idea? |
dbaston
reviewed
Jul 26, 2024
mwtoews
force-pushed
the
fix-compute-maximum-iterations
branch
2 times, most recently
from
c4137a6 to
ebee570
Compare
dr-jts
reviewed
Jul 26, 2024
mwtoews
force-pushed
the
fix-compute-maximum-iterations
branch
from
ebee570 to
da7ed5c
Compare
mwtoews
added a commit
that referenced
this pull request
Jul 27, 2024
|
Cherry-picked to the |
Agreed, probably no need to add to NEWS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with
MaximumInscribedCircle::computeMaximumIterationsthat sometimes returns bogus values.For example, with this example the number of iterations is needed by
LargestEmptyCircle::compute(). The geometry calculates ncells=0.0903549, which would normally have a log value -2.40401. But the early cast tosize_tdoesn't correctly handle negative values meaning the maxIter is either 0 or 4294965296 (i.e. it's up to the compiler to decide). This fix will re-establish the maxIter to 4000 for small "ncells" values (less than 1). The bug with MSVC 32-bit is that it was zero, meaning no iteration.Also clean-up one MSVC warning.Closes #1129