Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEOSConcaveHullOfPolygons: Avoid crash on zero-area input #1076

Merged
merged 4 commits into from
Jun 20, 2024
Merged

GEOSConcaveHullOfPolygons: Avoid crash on zero-area input #1076

merged 4 commits into from
Jun 20, 2024

Conversation

dbaston
Copy link
Member

@dbaston dbaston commented Apr 20, 2024

Resolves #1071

@dbaston dbaston requested a review from dr-jts April 20, 2024 21:55
dr-jts
dr-jts reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@dr-jts dr-jts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to go further than this and return an empty hull for any input with zero area (not just a zero-area envelope).

@dr-jts dr-jts added the Bug label Apr 22, 2024
@dbaston dbaston merged commit fc0722f into libgeos:main Jun 20, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-jts dr-jts dr-jts left review comments

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault in polygon.cpp
2 participants
@dbaston @dr-jts