MinimumClearance: Avoid crash on NaN inputs (#1082)

Resolves #1079
libgeos · Apr 25, 2024 · 9d41562 · 9d41562
1 parent cbf94fe
commit 9d41562
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/precision/MinimumClearance.cpp b/src/precision/MinimumClearance.cpp
@@ -176,6 +176,10 @@ MinimumClearance::compute()
     MinClearanceDistance mcd;
     auto nearest = tree->nearestNeighbour(mcd);
 
+    if (nearest.first == nullptr || nearest.second == nullptr) {
+        throw util::GEOSException("Failed to find nearest items");
+    }
+
     minClearance = mcd.distance(nearest.first, nearest.second);
 
     const std::vector<Coordinate>* minClearancePtsVec = mcd.getCoordinates();

diff --git a/tests/unit/capi/GEOSMinimumClearanceTest.cpp b/tests/unit/capi/GEOSMinimumClearanceTest.cpp
@@ -120,4 +120,14 @@ void object::test<5>
                   geos::DoubleInfinity);
 }
 
+template<>
+template<>
+void object::test<6>
+()
+{
+    input_ = GEOSGeom_createPointFromXY(std::numeric_limits<double>::quiet_NaN(), 1);
+    double d;
+    ensure_equals(GEOSMinimumClearance(input_, &d), 2);
+}
+
 } // namespace tut