Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator __in to es.filter() for search in list. #53

Open
wants to merge 2 commits into
base: feature/fix-filters
Choose a base branch
from

Conversation

onegreyonewhite
Copy link
Contributor

This can fix #50 and good update for PR #51

@lauxley
Copy link
Contributor

lauxley commented Jul 26, 2016

Yes i think it would be a good idea but does it still work with strings ? .filter(X__contains='test') used to return documents with not analyzed fields like 'foo test bar'. If not we might need another lookup, because it wouldn't be backward compatible and i don't see a reason to break this.

@onegreyonewhite onegreyonewhite changed the title Change 'match' to 'filtered' for __contains case. Add operator __in to es.filter() for search in list. Jul 26, 2016
@onegreyonewhite
Copy link
Contributor Author

onegreyonewhite commented Jul 29, 2016

@lauxley , I do not quite understand you.
In #50, I raised the question of how to work with lists. I think that it is necessary to share the search for relevant lists and string.
This pull request decide whether to #50.
In order to carry out a filtering of the list of line, I'll think separately.
And I use __in, for backward.

@lauxley
Copy link
Contributor

lauxley commented Jul 29, 2016

Adding the __in lookup seems like a good idea, i didn't say otherwise so why do you say you don't understand me ? I can't merge the pull request just yet though, i want to check how it behaves with different types and re-check what problem it solves.
And a test would be nice :)

@onegreyonewhite
Copy link
Contributor Author

@lauxley, my English is not so good as I want it be. That's why I really can't understand the meaning of some phrases. I understand the words separetly, but the whole phrase sometimes seems difficult to get for me. But I have my wife, who helps me sometimes in English:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants