Config refacto #27
Open
Config refacto #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* to avoid using any global variable * get rid of every occurences of 'libe' * cleanup how settings are passed and used * get rid of jdpicker (it is easy enough to hook any date picker if you want one) Note that there is still a lot of TODOs in the code, and that this will make other pull requests hard to merge (some files got deleted, a lot of code was moved).
|
damnit, i wanted to squash all the commits, i forgot the first one :( |
…ssion management, added a few TODOs and the trigger digitalpaper-token-received
…the backward compatibility with APIs.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactorisation, the goals were :
* to avoid using any global variable
* get rid of every occurences of 'libe'
* cleanup how settings are passed and used
* get rid of jdpicker (it is easy enough to hook any date picker if you want one)
Note that there is still a lot of TODOs in the code, and that this will make other pull requests hard to merge (some files got deleted, others got moved)