browser history #19
browser history #19
Conversation
|
👍 Souen Boniface likes this ! |
| function bindHistory() { | ||
| jQuery(window).bind('popstate', function(e) { | ||
| // close the window in case we hit the back button | ||
| $.fn.closeDOMWindow(); |
There was a problem hiding this comment.
Not passing settings to the closeDOMWindow() call will be a problem: Not only will that break some custom usage of DOMWindow (since the call will use an empty object for settings) but it means our own functionCallOnClose won't be called. At the very leasts this means the CSS overflow property won't properly be reset on the body.
I'm not sure we can easily solve this without modifying/removing DOMWindow :(
There was a problem hiding this comment.
Is DOMWindow supposed to work with more than one window ? if not we could use a global variable for settings, it still wouldn't be a good design but at least would fix this without too much hassle. I think it would be better than passing the settings every time, which doesn't really make sense anyway ?
|
Closing this for a more practical and clean pull request see #25 |
Note that there is a bug in DOMWindow which make this fail when one close the window with the close button (not with escape or with a click on the overlay)