Require libcdio at least 2.0.0 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I doubt 0.83 still works, although I haven't check (and don't have much interest in checking). A *lot* has gone on since 0.83 so even if it still works, strong-arming folks to get up to 2.0.0 is probably a good thing (from the developer side if not the end-user side) in the long run. And it isn't like 2.0.0 from the last day of 2017 isn't is all *that* new.
|
@boretom @eshattow @enzo1982 : Your thoughts? See also #14 (comment) |
enzo1982
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
I just checked and the latest libcdio-paranoia still builds against libcdio 0.83. But nevertheless I'm all for making this change.
Many bugs have been fixed in the past years and I remember a few times where I tried to reproduce an issue just to find out that it had long been fixed, but the user's distribution still packaged an old libcdio release.
|
@enzo1982 Thanks for the feedback. I should also note that there are a number of CVE's logged for libcdio pre 2.0.0. |
boretom
approved these changes
Mar 12, 2020
|
Ok. Let's do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I doubt 0.83 still works, although I haven't checked (and don't have much
interest in checking).
A lot has gone on since 0.83 so even if it still works, strong-arming
folks to get up to 2.0.0 is probably a good thing (from the developer
side if not the end-user side) in the long run.
And it isn't like 2.0.0 from the last day of 2017 is is all that new.