Release workflow improvements #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I should add a version number in the asset with the source code, probably. |
qmonnet
force-pushed
the
pr/release-assets
branch
6 times, most recently
from
aaa0971 to
e3550ed
Compare
With the recent improvements to the feature detection system, it's trival to keep the stderr output for commands when passing V=1 to the make invocation. This output is useful for debugging feature detection. Signed-off-by: Quentin Monnet <[email protected]>
We do not need to ship both uncompresed and compressed binaries on releases. The compressed archives are enough. One advantage is that we avoid having binaries named "bpftool-<arch>": all binaries, once the archives are uncompresed, are "bpftool". Signed-off-by: Quentin Monnet <[email protected]>
Add sha256 sum files for the archives produced for releases and containing bpftool binaries, so that users can make sure that the file were correctly downloaded. Signed-off-by: Quentin Monnet <[email protected]>
The source code archives generated by GitHub for bpftool releases do not contain the code for submodules, or the Git submodule configuration necessary to easily retrieve these modules. This makes it difficult to build bpftool by simply fetching the sources from releases. This commit adds a new release asset, an archive containing the code for bpftool and its submodules (libbpf), stripped from their respective .git subdirectories. Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
pr/release-assets
branch
from
e3550ed to
3747a54
Compare
mtardy
approved these changes
Mar 22, 2023
qmonnet
force-pushed
the
pr/release-assets
branch
2 times, most recently
from
507d0f4 to
c16fb71
Compare
Some packages that we install in the Docker container for building the arm64 binary for releases are not necessary. We can accelerate the workflow a little by skipping them. We need libstd++ and zlib, which were likely pulled by one of the removed packages so far. Now that clang and llvm-strip are no longer available from $PATH, we must pass the path to the downloaded versions explicitly so that bpftool can use it when probing for the clang-bpf-co-re feature. Signed-off-by: Quentin Monnet <[email protected]>
This commit brings some cosmetic changes to the workflow to make it look more consistent with the older workflows. No functional change, apart from the additional check on the .skeletons feature when testing binaries. Signed-off-by: Quentin Monnet <[email protected]>
The CI workflow for static builds against the LLVM binaries would recompile the LLVM libraries for static linking before building bpftool. The process is long, and the workflow would take around 80 minutes to complete. We can instead download binaries shipped with LLVM releases. The build works just as well, but the workflow should take around 2 minutes only. Based after the work from Mahé on the relase workflow. Signed-off-by: Quentin Monnet <[email protected]>
Add a simple script relying on the "gh api" command to update release assets on GitHub, in order to set labels and make the list of assets easier to read. Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
pr/release-assets
branch
from
c16fb71 to
ff0ba21
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit contains some improvements for feature detection (dump
stderroutput onV=1to see what's missing when detection fails).The rest of the PR focuses on the release GitHub workflow, to bring various improvements. Please see individual commits for details.
Cc @mtardy