ci: Update build.yaml to include Ubuntu 24.04 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0d33ngr
force-pushed
the
update-github-workflow
branch
from
65b5f21 to
6432da3
Compare
|
Thanks a lot! The CI fails on Ubuntu 24.04, though. I forgot we needed #152 to be addressed before using Ubuntu 24.04. Once the fix makes it to bpf-next, it will be pulled when we update the mirror. It will need an additional commit in this repo to compensate for the feature detection in the kernel repo, and then we'll be able to merge your change. |
|
Okay. Thank you :) |
Signed-off-by: Jeffrey <[email protected]>
qmonnet
force-pushed
the
update-github-workflow
branch
from
6432da3 to
7ad2fbc
Compare
The Ubuntu 20.04-based runners have been deprecated by GitHub at the beginning of this month, and are expected to go fully unsupported by 2025-04-01. Let's remove it from the workflow file. Link: actions/runner-images#11101 Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
update-github-workflow
branch
2 times, most recently
from
99a98bc to
cf462c6
Compare
Add the probe to test whether we need to link against the zstd library to use libelf in bpftool. This should ideally have been merged before commit 67f1758 ("bpftool: Link zstd lib required by libelf"), where we have the Makefile use the actual feature, but I forgot to add the probe when synchronising the repository. Elfutils commit a5b07cdf9c49 adds support for ZSTD compression, first shipped with elfutils 0.189. Distros now have it; for example, Ubuntu 22.04 ships version 0.186 (or 0.188 in backports), but Ubuntu 24.04 has 0.189 or 0.190 depending on the arch. Link: https://sourceware.org/git/?p=elfutils.git;a=commit;h=a5b07cdf9c491fb7a4a16598c482c68b718f59b9 Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
update-github-workflow
branch
from
cf462c6 to
3b812c2
Compare
|
Apologies, I synchronized the repo and the Makefile fix is in, but it seems I'm still missing something on the probing side - so the build workflow on Ubuntu 24.04 still fails. I'll need to look into it more. |
qmonnet
force-pushed
the
update-github-workflow
branch
6 times, most recently
from
2125fb3 to
fa94535
Compare
Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
update-github-workflow
branch
from
fa94535 to
1a88cf7
Compare
|
OK I've got the fix but the |
Use Ubuntu 24.04 instead of 22.04 (when we use a single version, not for the build test Matrix where we want to test both), except for the job where we package the release (where we're not really tied to a specific version and can just go with ubuntu-latest). Signed-off-by: Quentin Monnet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to close #177