Missing bpffs mount when pinning maps for prog load (`pinmaps`) #146

qmonnet · 2024-05-27T23:40:54Z

Looking at the code around mounting the bpffs in bpftool's prog.c, I see that we don't call mount_bpffs_for_pin() for the directory where the user wants to pin maps, if pinmaps is passed:

	err = mount_bpffs_for_pin(pinfile, !first_prog_only);
	if (err)
		goto err_close_obj;

	if (first_prog_only) {
		prog = bpf_object__next_program(obj, NULL);
		if (!prog) {
			p_err("object file doesn't contain any bpf program");
			goto err_close_obj;
		}

		if (auto_attach)
			err = auto_attach_program(prog, pinfile);
		else
			err = bpf_obj_pin(bpf_program__fd(prog), pinfile);
		if (err) {
			p_err("failed to pin program %s",
			      bpf_program__section_name(prog));
			goto err_close_obj;
		}
	} else {
		if (auto_attach)
			err = auto_attach_programs(obj, pinfile);
		else
			err = bpf_object__pin_programs(obj, pinfile);
		if (err) {
			p_err("failed to pin all programs");
			goto err_close_obj;
		}
	}

	if (pinmaps) {

		// XXX No guarantee that the bpffs is mounted for directory pinmaps, here

		err = bpf_object__pin_maps(obj, pinmaps);
		if (err) {
			p_err("failed to pin all maps");
			goto err_unpin;
		}
	}

I haven't tested it though, but I expect the map pinning to fail if we pass a pinmaps directory that is not under the bpffs.

Originally posted by @qmonnet in #100 (comment)

The text was updated successfully, but these errors were encountered:

chentao-kernel · 2024-07-02T03:51:59Z

Hi, qmonnet
The problem seems still exist in 6.10-rc4, when i run a test case:

libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS                                                                       │
Error: failed to pin all maps

No one fixes it right？Maybe i can submit a patch

qmonnet · 2024-07-02T08:25:57Z

Correct, nobody has fixed the issue, and a patch is welcome, thanks! :)

chentao-kernel · 2024-07-02T08:46:39Z

Correct, nobody has fixed the issue, and a patch is welcome, thanks! :)

Thank you for your reply, i will send it later

As qmonnet said [1], map pinning will fail if the pinmaps path not under the bpffs, like: libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS Error: failed to pin all maps [1]: libbpf/bpftool#146 Fixes: 3767a94 ("bpftool: add pinmaps argument to the load/loadall") Signed-off-by: Tao Chen <[email protected]>

qmonnet · 2024-07-02T16:16:29Z

https://lore.kernel.org/bpf/[email protected]/t/#u

As Quentin said [0], BPF map pinning will fail if the pinmaps path is not under the bpffs, like: libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS Error: failed to pin all maps [0] libbpf/bpftool#146 Fixes: 3767a94 ("bpftool: add pinmaps argument to the load/loadall") Signed-off-by: Tao Chen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: Quentin Monnet <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]

qmonnet · 2024-07-02T16:34:54Z

Daniel just merged the patch to bpf-next, thanks a lot! It will land in this repo at the next sync.

chentao-kernel · 2024-07-03T03:16:11Z

Daniel just merged the patch to bpf-next, thanks a lot! It will land in this repo at the next sync.

Hi qmonnet,
Thank you for merging my patch!

As Quentin said [0], BPF map pinning will fail if the pinmaps path is not under the bpffs, like: libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS Error: failed to pin all maps [0] libbpf#146 Fixes: 3767a94b3253 ("bpftool: add pinmaps argument to the load/loadall") Signed-off-by: Tao Chen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: Quentin Monnet <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]

As Quentin said [0], BPF map pinning will fail if the pinmaps path is not under the bpffs, like: libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS Error: failed to pin all maps [0] #146 Fixes: 3767a94b3253 ("bpftool: add pinmaps argument to the load/loadall") Signed-off-by: Tao Chen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: Quentin Monnet <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]

[ Upstream commit da5f8fd ] As Quentin said [0], BPF map pinning will fail if the pinmaps path is not under the bpffs, like: libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS Error: failed to pin all maps [0] libbpf/bpftool#146 Fixes: 3767a94 ("bpftool: add pinmaps argument to the load/loadall") Signed-off-by: Tao Chen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: Quentin Monnet <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected] Signed-off-by: Sasha Levin <[email protected]>

[ Upstream commit da5f8fd1f0d393d5eaaba9ad8c22d1c26bb2bf9b ] As Quentin said [0], BPF map pinning will fail if the pinmaps path is not under the bpffs, like: libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS Error: failed to pin all maps [0] libbpf/bpftool#146 Fixes: 3767a94 ("bpftool: add pinmaps argument to the load/loadall") Signed-off-by: Tao Chen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: Quentin Monnet <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected] Signed-off-by: Sasha Levin <[email protected]> (cherry picked from commit d98010b214a9bfb350a6ab6dc3d123c7f9700f5a)

[ Upstream commit da5f8fd ] As Quentin said [0], BPF map pinning will fail if the pinmaps path is not under the bpffs, like: libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS Error: failed to pin all maps [0] libbpf/bpftool#146 Fixes: 3767a94 ("bpftool: add pinmaps argument to the load/loadall") Signed-off-by: Tao Chen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: Quentin Monnet <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected] Signed-off-by: Sasha Levin <[email protected]>

[ Upstream commit da5f8fd1f0d393d5eaaba9ad8c22d1c26bb2bf9b ] As Quentin said [0], BPF map pinning will fail if the pinmaps path is not under the bpffs, like: libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS Error: failed to pin all maps [0] libbpf/bpftool#146 Fixes: 3767a94 ("bpftool: add pinmaps argument to the load/loadall") Signed-off-by: Tao Chen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: Quentin Monnet <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected] Signed-off-by: Sasha Levin <[email protected]> (cherry picked from commit 5c2be5d17ec6b5e6f790ad57dbda63f900d38b48)

[ Upstream commit da5f8fd ] As Quentin said [0], BPF map pinning will fail if the pinmaps path is not under the bpffs, like: libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS Error: failed to pin all maps [0] libbpf/bpftool#146 Fixes: 3767a94 ("bpftool: add pinmaps argument to the load/loadall") Signed-off-by: Tao Chen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: Quentin Monnet <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected] Signed-off-by: Sasha Levin <[email protected]>

[ Upstream commit da5f8fd1f0d393d5eaaba9ad8c22d1c26bb2bf9b ] As Quentin said [0], BPF map pinning will fail if the pinmaps path is not under the bpffs, like: libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS Error: failed to pin all maps [0] libbpf/bpftool#146 Fixes: 3767a94 ("bpftool: add pinmaps argument to the load/loadall") Signed-off-by: Tao Chen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: Quentin Monnet <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected] Signed-off-by: Sasha Levin <[email protected]> (cherry picked from commit 77bf25dab8ceea31428488637b272caa5708cf50)

[ Upstream commit da5f8fd ] As Quentin said [0], BPF map pinning will fail if the pinmaps path is not under the bpffs, like: libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS Error: failed to pin all maps [0] libbpf/bpftool#146 Fixes: 3767a94 ("bpftool: add pinmaps argument to the load/loadall") Signed-off-by: Tao Chen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: Quentin Monnet <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected] Signed-off-by: Sasha Levin <[email protected]>

[ Upstream commit da5f8fd1f0d393d5eaaba9ad8c22d1c26bb2bf9b ] As Quentin said [0], BPF map pinning will fail if the pinmaps path is not under the bpffs, like: libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS Error: failed to pin all maps [0] libbpf/bpftool#146 Fixes: 3767a94 ("bpftool: add pinmaps argument to the load/loadall") Signed-off-by: Tao Chen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: Quentin Monnet <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected] Signed-off-by: Sasha Levin <[email protected]> (cherry picked from commit 77bf25dab8ceea31428488637b272caa5708cf50)

[ Upstream commit da5f8fd ] As Quentin said [0], BPF map pinning will fail if the pinmaps path is not under the bpffs, like: libbpf: specified path /home/ubuntu/test/sock_ops_map is not on BPF FS Error: failed to pin all maps [0] libbpf/bpftool#146 Fixes: 3767a94 ("bpftool: add pinmaps argument to the load/loadall") Signed-off-by: Tao Chen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: Quentin Monnet <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected] Signed-off-by: Sasha Levin <[email protected]>

qmonnet assigned chentao-kernel Jul 2, 2024

qmonnet closed this as completed Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Missing bpffs mount when pinning maps for prog load (`pinmaps`) #146

Missing bpffs mount when pinning maps for prog load (`pinmaps`) #146

qmonnet commented May 27, 2024

chentao-kernel commented Jul 2, 2024

qmonnet commented Jul 2, 2024

chentao-kernel commented Jul 2, 2024

qmonnet commented Jul 2, 2024

qmonnet commented Jul 2, 2024

chentao-kernel commented Jul 3, 2024

Missing bpffs mount when pinning maps for prog load (pinmaps) #146

Missing bpffs mount when pinning maps for prog load (pinmaps) #146

Comments

qmonnet commented May 27, 2024

chentao-kernel commented Jul 2, 2024

qmonnet commented Jul 2, 2024

chentao-kernel commented Jul 2, 2024

qmonnet commented Jul 2, 2024

qmonnet commented Jul 2, 2024

chentao-kernel commented Jul 3, 2024

Missing bpffs mount when pinning maps for prog load (`pinmaps`) #146

Missing bpffs mount when pinning maps for prog load (`pinmaps`) #146