Give preference to ELF symbolization for kernel addresses #970
+66
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a side effect of commit 7ee10af ("Merge SymResolver::find_code_info() into SymResolver::find_sym()") we changed the behavior of the kernel resolver in that where previously it would consult the ELF resolver for source code information, it no longer did so. That was mostly a result of the kernel resolver giving preference to the internally used KSymResolver, as opposed to the ElfResolver. This change adjusts the logic to make sure that if an ElfResolver is present, we end up using it for symbolization. Signed-off-by: Daniel Müller <[email protected]>
danielocfb
force-pushed
the
topic/kernel-elf-pref
branch
from
21b7aed to
9af1396
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
- Coverage 94.89% 94.81% -0.08%
==========================================
Files 58 58
Lines 10725 10725
==========================================
- Hits 10177 10169 -8
- Misses 548 556 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side effect of commit 7ee10af ("Merge
SymResolver::find_code_info() into SymResolver::find_sym()") we changed the behavior of the kernel resolver in that where previously it would consult the ELF resolver for source code information, it no longer did so. That was mostly a result of the kernel resolver giving preference to the internally used KSymResolver, as opposed to the ElfResolver. This change adjusts the logic to make sure that if an ElfResolver is present, we end up using it for symbolization.