Support multiple results sets for go 1.8

[maddyblue]

@kardianos

---

This change is

[tamird]

Consider adding 1.8 or tip to .travis with failures allowed. Current code here doesn't compile under 1.8.

---

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

---

nextresultset_test.go, line 26 at r1 (raw file):

      }
  }
  if !rows.NextResultSet() {

HasNextResultSet

---

Comments from Reviewable

[tamird]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

---

nextresultset_test.go, line 26 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

HasNextResultSet

Rather, `HasNextResultSet` should be removed - the methods implemented on `*rows` appear to be incorrect.

---

Comments from Reviewable

[maddyblue]

Yes, it does compile under 1.8. See "TestMultiple" which only appears in the travis tip builds: https://travis-ci.org/lib/pq/jobs/172536052

---

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

---

nextresultset_test.go, line 26 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

Rather, HasNextResultSet should be removed - the methods implemented on *rows appear to be incorrect.

No, this is correct. That method is only available to the driver, not on a rows. See https://tip.golang.org/pkg/database/sql/#Rows.NextResultSet and https://docs.google.com/document/d/1F778e7ZSNiSmbju3jsEWzShcb8lIO4kDyfKDNm4PNd8/edit from which this code was taken from.

---

Comments from Reviewable

[maddyblue]

Renamed the test file because it may be used for the other 1.8 features. Added tests to ensure that extra, unused results don't change future results.

[freeformz]

Please don't use reviewable.

[tamird]

Ah, I was under the misapprehension that the database/sql.Rows was an interface, but it is not. LGTM

[itsjamie]

Simply marking this as related to #531