feat: ability to hide previous comments & fix for summary issue #65
+438
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Always add to summary
feat: always add to summary
feat: always add to summary
…n/terraform-change-summary into always-add-to-summary
fix: moving pr comment code to pull request check and removing exits
…n/terraform-change-summary into always-add-to-summary
fix: adding bool flag to add comment instead of exiting early
…n/terraform-change-summary into minimize-prev-comment
…n/terraform-change-summary into minimize-prev-comment
…n/terraform-change-summary into minimize-prev-comment
…n/terraform-change-summary into minimize-prev-comment
feat: minimize previous comment
…n/terraform-change-summary into minimize-prev-comment
feat: Minimize prev comment
chore: removed action commiting the dist folder
minimize prev comment
jburns24
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Reviewed and tested the fork locally. I have verified that these changes do in fact resolve issue #61 and the hide-previous-comments feature works as intended. I agree with this approach for #57 as it maintains the comment history. Almost in favor of this defaulting to true
@DeWildeDaan Thank you for the well authored contribution.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
# [1.6.0](v1.5.0...v1.6.0) (2024-09-03) ### Features * ability to hide previous comments & fix for summary issue ([#65](#65)) ([08ba12c](08ba12c))
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some issues created for this action:
fix: It addresses issue non-Pull Request workflows causing warning and no plan is posted to the job summary #61
My guess why this happened: on line 136 & 145 (https://github.com/liatrio/terraform-change-pr-commenter/blob/main/index.js#L131-L146) the process exits if certain conditions are met. This prevents the summary from being set.
By removing the
process.exit(0)lines and using a 'createComment' flag that is set to false when those conditions are met, we eliminate this 'bug'.feat: It adds the feature to hide previous comments in relation to issue Update existing comment in place #57
As mentioned in that issue, updating comments in place isn't really the best idea. So I added the option to hide/minimize previous comment created by the action.
This feature is also added to the action-test.yml to test its functionality.
docs: I also took the liberty to updating the README.MD, adding all (new) inputs and adding a little 'OpenTofu' section + fixing a little typo.
(I'm using my forked version of this action and it works great 😄 )