Multiple feature additions #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
someshkoli
commented
Mar 13, 2024
•
someshkoli
commented
- add workflow link to comment (Link in plan comment to workflow #14)
- Add header and footer to the comment
- quite mode. dont comment if there are no changes (Add a quiet mode where the action doesn't leave a comment if there are no planned changes #11)
- comment header option - comment footer option - workflow link option - quite mode option
feat: multiple features
Closed
RobertKelly
reviewed
Mar 13, 2024
| @@ -113,13 +126,21 @@ try { | |||
| process.exit(0); | |||
| } | |||
|
|
|||
| if (quiteMode && hasNoChanges) { | |||
There was a problem hiding this comment.
Suggested change
| if (quiteMode && hasNoChanges) { | |
| if (quietMode && hasNoChanges) { |
RobertKelly
reviewed
Mar 13, 2024
| @@ -113,13 +126,21 @@ try { | |||
| process.exit(0); | |||
| } | |||
|
|
|||
| if (quiteMode && hasNoChanges) { | |||
| core.info("Quite mode is enabled and there are no changes to the infrastructure.") | |||
There was a problem hiding this comment.
Suggested change
| core.info("Quite mode is enabled and there are no changes to the infrastructure.") | |
| core.info("Quiet mode is enabled and there are no changes to the infrastructure.") |
RobertKelly
reviewed
Mar 13, 2024
| comment-header: "BIG HEADER" | ||
| comment-footer: "BIG FOOTER" | ||
| include-workflow-link: "true" | ||
| quite: "true" |
There was a problem hiding this comment.
Suggested change
| quite: "true" | |
| quiet: "true" |
RobertKelly
reviewed
Mar 13, 2024
| @@ -8,26 +8,37 @@ const myToken = core.getInput('github-token'); | |||
| const octokit = github.getOctokit(myToken); | |||
| const context = github.context; | |||
| const inputFilenames = core.getMultilineInput('json-file'); | |||
| const commentHeader = core.getMultilineInput('comment-header'); | |||
| const commentFooter = core.getMultilineInput('comment-footer'); | |||
| const quiteMode = core.getMultilineInput('quite'); | |||
There was a problem hiding this comment.
Suggested change
| const quiteMode = core.getMultilineInput('quite'); | |
| const quietMode = core.getMultilineInput('quiet'); |
RobertKelly
requested changes
Mar 13, 2024
|
This pr has become absolute mess in attempt to get things working ☠️ |
|
Closing in prefrence to #60 |
mitchell-liatrio
added a commit
that referenced
this pull request
May 8, 2024
* feat: multiple features - comment header option - comment footer option - workflow link option - quite mode option * chore: update typos * chore: add debug logs * chore: add debug logs * chore: add debug logs * chore: add newline --------- Co-authored-by: Mitchell Phillips <[email protected]>
mitchell-liatrio
added a commit
that referenced
this pull request
May 8, 2024
mitchell-liatrio
added a commit
that referenced
this pull request
May 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2024
# [1.5.0](v1.4.5...v1.5.0) (2024-05-08) ### Features * additional feature additions ([#62](#62)) ([1465fa2](1465fa2)) * multiple feature addition [#58](#58) ([#60](#60)) ([01f0321](01f0321)) ### Reverts * Revert " feat: multiple feature addition #58 (#60)" (#63) ([ab68bb6](ab68bb6)), closes [#58](#58) [#60](#60) [#63](#63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.